Open victor-yanev opened 4 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.90%. Comparing base (
1733949
) to head (2714de0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failed conditions
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
Description:
Problem
Currently the way that the
contractActionIndexOfCurrentFrame
is tracked insideOpcodeTracer
is not exactly how it is done in theHederaTracer
, where the list of contract actions is built and we are still using the mono code in theweb3
module, so we need to refactor this to be identical to what is done inHederaTracer
. We need to copy the logic from there and increment thecontractActionIndexOfCurrentFrame
in the places where items are pushed to theallActions
list inHederaTracer
.This PR
Copies the way contract actions are added to the
allActions
list in HederaTracerinit
,tracePrecompileResult
,traceAccountCreationResult
, andtracePostExecution
tracePrecompileResult
method from theHederaOperationTracer
interface.TODO:
contract/results/{transactionIdOrHash}/opcodes
endpoint to replay the transactionOpcodeTracer
to verify that thecontractActionIndexOfCurrentFrame
is correct when we hit thetracePrecompileCall
method for the HTS callsRelated issue(s):
Fixes #8639
Notes for reviewer:
Checklist