hashgraph / hedera-mirror-node

Hedera Mirror Node archives data from consensus nodes and serves it via an API
Apache License 2.0
128 stars 108 forks source link

Reducing cache-control for scheduled transactions. #9327

Closed mgoelswirlds closed 1 week ago

mgoelswirlds commented 2 weeks ago

Description: Reduce cache for the transactions endpoint with scheduled transactions.

This PR modifies

Related issue(s):

Fixes #9174

Notes for reviewer: Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.57%. Comparing base (90dca10) to head (887ad00). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9327 +/- ## ============================================ - Coverage 92.68% 92.57% -0.11% - Complexity 6943 7047 +104 ============================================ Files 896 914 +18 Lines 29553 29831 +278 Branches 3745 3773 +28 ============================================ + Hits 27390 27617 +227 - Misses 1399 1445 +46 - Partials 764 769 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgoelswirlds commented 2 weeks ago

I still need to address the new comments on the PR @steven-sheehy I mistakenly asked for a re-review.

xin-hedera commented 1 week ago

I approved it since I'm off on Monday so don't unnecessarily block the PR. There is still one minor change I asked for.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud