hashgraph / hedera-mirror-node

Hedera Mirror Node archives data from consensus nodes and serves it via an API
Apache License 2.0
147 stars 112 forks source link

Check extra success codes for transactions result parameter #9352

Closed steven-sheehy closed 2 months ago

steven-sheehy commented 2 months ago

Description:

Check extra success codes for transactions result parameter like we do in importer.

Related issue(s):

Fixes #9351

Notes for reviewer:

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.52%. Comparing base (307d371) to head (f308000). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9352 +/- ## ========================================= Coverage 92.52% 92.52% Complexity 7012 7012 ========================================= Files 904 904 Lines 29669 29669 Branches 3751 3751 ========================================= + Hits 27451 27452 +1 Misses 1447 1447 + Partials 771 770 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

steven-sheehy commented 2 months ago

The last commit to main seems to have some test failures not related to my changes.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud