`TransactionId` should not be regenerated if set manually by a user

[rwalworth]

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

Currently, setting a Transaction's TransactionId does not impact the Transaction's ability to regenerate its TransactionId. However, looking at Java and Go SDKs, the TransactionId gets locked when it is set manually. Then, when the Transaction is determining if it should regenerate its TransactionId or not, it looks at the transaction ID regeneration policy as well as if the TransactionId is locked. If the TransactionId is locked (which it is if its set manually by a user), it does not regenerate.

Steps to reproduce

1. Set a TransactionId for a Transaction.
2. Attempt to submit the Transaction and have it expire.
3. Observe the TransactionId get regenerated.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file. A more detailed general documentation of the GitHub PR workflow can be found here.

• [ ] Claim this issue: Comment below that you are interested in working on the issue
• [ ] Wait for assignment: A community member with the given rights will add you as an assignee of the issue
• [ ] Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
• [ ] Check out the forked repository
• [ ] Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
• [ ] Solve the issue in your branch.
• [ ] Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
• [ ] Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
• [ ] Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
• [ ] Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
• [ ] You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

Operating system

Other

[Atharva1723]

Can I work on this issue?

[Atharva1723]

The transaction id is referenced for which example or it is generic. Not sure what to do?

[rwalworth]

The transaction id is referenced for which example or it is generic. Not sure what to do?

How it works now, when a TransactionId is set by a user, the processing will still regenerate the TransactionId if the Transaction expires and mTransactionIdRegenerationPolicy is set to true. This is not desired behavior. If the TransactionId is set manually by the user (by calling setTransactionId()), it shouldn't be regenerated even if mTransactionIdRegenerationPolicy is set to true.