hashgraph / hedera-sdk-go

Hedera™ Hashgraph SDK for Go
https://docs.hedera.com/docs/hedera-sdks
Apache License 2.0
104 stars 65 forks source link

feat(HIP-869): Dynamic Address Book #1011

Closed 0xivanov closed 2 months ago

0xivanov commented 3 months ago

Description: HIP-869: Dynamic Address Book

Related issue(s):

Fixes #965 #966 #967 https://github.com/hashgraph/hedera-sdk-go/issues/968 https://github.com/hashgraph/hedera-sdk-go/issues/969

Notes for reviewer:

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 76.01411% with 136 lines in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (9b58cb6) to head (b6953c3). Report is 2 commits behind head on main.

Files Patch % Lines
node_update_transaction.go 79.22% 37 Missing and 6 partials :warning:
node_create_transaction.go 81.18% 31 Missing and 4 partials :warning:
node_delete_transaction.go 77.35% 23 Missing and 1 partial :warning:
endpoint.go 44.44% 15 Missing :warning:
ipv4_address.go 33.33% 12 Missing :warning:
ipv4_address_part.go 12.50% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1011 +/- ## ========================================== + Coverage 73.55% 73.64% +0.08% ========================================== Files 168 171 +3 Lines 23755 24299 +544 ========================================== + Hits 17473 17894 +421 - Misses 5576 5688 +112 - Partials 706 717 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud