hashgraph / hedera-sdk-go

Hedera™ Hashgraph SDK for Go
https://docs.hedera.com/docs/hedera-sdks
Apache License 2.0
104 stars 65 forks source link

feat: Add missing Key logic #1016

Closed 0xivanov closed 2 months ago

0xivanov commented 3 months ago

Description:

Add missing From/To bytes functionality to Keys

Related issue(s):

Fixes #1015

Notes for reviewer:

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.55%. Comparing base (c8d9fb0) to head (e72a960). Report is 1 commits behind head on main.

Files Patch % Lines
crypto.go 77.77% 1 Missing and 1 partial :warning:
transaction.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1016 +/- ## ========================================== + Coverage 73.52% 73.55% +0.02% ========================================== Files 168 168 Lines 23733 23755 +22 ========================================== + Hits 17450 17473 +23 + Misses 5578 5576 -2 - Partials 705 706 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud