Closed gsstoykov closed 5 months ago
Attention: Patch coverage is 71.07438%
with 35 lines
in your changes are missing coverage. Please review.
Project coverage is 72.86%. Comparing base (
a3f6b87
) to head (6647b38
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
This PR introduces the SDK capability for querying
AccountInfo
,ContractInfo
,AccountBalance
andTokenRelationships
from the Mirror Node. Currently not all Mirror Node queries will be used by the SDK but theAccountInfo
andTokenRelationship
queries are needed in order to populate the SDK fields forTokenBalances
andTokenRelationships
thus resolving the deprecations described in https://github.com/hashgraph/hedera-sdk-reference/issues/144.Related issue(s):
Fixes https://github.com/hashgraph/hedera-sdk-go/issues/841
Notes for reviewer: Currently the GO SDK has no straightforward way of verifying JSON objects. A note for future implementations would be adding a more sophisticated JSON validation.
At some point we should discuss approaches for testing the Mirror Node responses. Currently the responses are only validated through the flows of the integration tests. All tests including
AccountInfo
,ContractInfo
,AccountBalance
andTokenRelationships
serve as validation of the queries.Tests and examples are now dependant on Mirror Node update times so data from the queries will be assumed to be valid after a 2-3 second delay. Currently there is no way for working around that delay time as it is dependant on the Mirror Node itself.
Checklist