search

hashgraph / hedera-sdk-go

Hedera™ Hashgraph SDK for Go
https://docs.hedera.com/docs/hedera-sdks
Apache License 2.0
108 stars 65 forks source link

Consolidate on higher SDK code coverage #931

Closed gsstoykov closed 3 months ago

gsstoykov commented 5 months ago

Problem

Currently SDK CI is expecting 72.74% code coverage and results in failure when we go below that point. This causes SDK PRs to constantly fail due to us being codecov/project — 72.57% (-0.17%) (at the point of writing). This constantly enforces us to implement for example one test to raise the coverage so that CI passes.

Solution

Consolidate on higher SDK code coverage(~80%) and keep strict test plans for not going below that point.

Alternatives

No response

0xivanov commented 3 months ago

In the last couple of months we've been slowly increasing the project code cov and now it's 73.8%, which is high enough for the CI checks to pass