hashgraph / hedera-sdk-go

Hedera™ Hashgraph SDK for Go
https://docs.hedera.com/docs/hedera-sdks
Apache License 2.0
88 stars 64 forks source link

fix: Get cost for `TransactionReceiptQuery` and `AccountBalanceQuery` #993

Closed 0xivanov closed 1 month ago

0xivanov commented 2 months ago

Description: TransactionReceiptQuery and AccountBalanceQuery do not call getCost in it's execution flow. Make it's flow similar to TransactionRecordQuery.

Related issue(s): The branch name should be "receipt" instead of "record".

Fixes #990

Notes for reviewer:

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (6c3b5c8) to head (b047966).

Files Patch % Lines
transaction_receipt_query.go 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #993 +/- ## ======================================= Coverage 73.52% 73.52% ======================================= Files 168 168 Lines 23748 23733 -15 ======================================= - Hits 17460 17450 -10 + Misses 5581 5578 -3 + Partials 707 705 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud