hashgraph / hedera-sdk-js

Hedera™ Hashgraph SDK for JavaScript/TypeScript
https://docs.hedera.com/guides/docs/sdks
Apache License 2.0
277 stars 145 forks source link

Missing transaction record fields for `AccountAllowanceAdjustmentTransaction` #1003

Closed SimiHunjan closed 2 years ago

SimiHunjan commented 2 years ago

Description

The transaction record for an AccountAllowanceAdjustmentTransaction() should return the corresponding adjustment that was made:

    /**
     * The current balances of any adjusted crypto allowances as a result of this
     * transaction. This field will only be populated for CryptoAdjustAllowanceTransaction.
     */

    repeated CryptoAllowance crypto_adjustments = 17;

    /**
     * The current balances of any adjusted non-fungible token allowances as a result of this
     * transaction. This field will only be populated for CryptoAdjustAllowanceTransaction.
     */
    repeated NftAllowance nft_adjustments = 18;

    /**
     * The current balances of any adjusted fungible token allowances as a result of this
     * transaction. This field will only be populated for CryptoAdjustAllowanceTransaction.
     */
    repeated TokenAllowance token_adjustments = 19;

This was included in the protobuf changes PR for this feature:

https://github.com/hashgraph/hedera-protobufs/pull/152/files#diff-282b092daf92d72c0573a1e75fb80df9c68ce358c2fab955956a5f744878fd5aR130

Steps to reproduce

Get the transaction record for an AccountAllowanceAdjustTransaction() and try to get the adjustment

Additional context

No response

Hedera network

previewnet

Version

v2.11.0-beta.1

Operating system

No response

janaakhterov commented 2 years ago

Implemented here: https://github.com/hashgraph/hedera-sdk-js/commit/64c26c80d81e0ae5344b540ffc23be5ed5d0b408