AccountAllowanceApproveTransaction response EMPTY_ALLOWANCES

hashgraph / hedera-sdk-js

Hedera™ Hashgraph SDK for JavaScript/TypeScript

https://docs.hedera.com/guides/docs/sdks

Apache License 2.0

277 stars 146 forks source link

AccountAllowanceApproveTransaction response EMPTY_ALLOWANCES #1104

Closed cmdhema closed 2 years ago

cmdhema commented 2 years ago

Description

Always precheck return 'EMPTY_ALLOWANCES' when I try AccountAllowanceApproveTransaction.

Steps to reproduce

Try to run

Additional context

Hedera network

testnet

Version

v2.13.1

Operating system

macOS

ed-marquez commented 2 years ago

The shipping example also fails: https://github.com/hashgraph/hedera-sdk-js/blob/main/examples/account-allowance.js

janaakhterov commented 2 years ago

Yea, this seems to be because the Java SDK updated the example and the JS didn't update along with it.

janaakhterov commented 2 years ago

This took a lot longer than it should have, but the issue is that the protobufs have been updated since the last release which contained breaking changes. Fixed here: ddc565a9b21cbe67bbd7e5f5d65f1618e48450cc and published a new @hashgraph/proto version. This shouldn't really require a SDK release from what I can tell, so if you add

  "overrides": {
    "@hashgraph/proto": "2.4.1"
  }

to your package.json it should work

cmdhema commented 2 years ago

@danielakhterov I try installed proto 2.4.1 but the result is same. I will wait sdk version up.

janaakhterov commented 2 years ago

Hmm, yea tested that as well with the example and it doesn't seem to work :( I think that's fine though since I will be releasing some SDK version tomorrow so you won't have to wait long.