hashgraph / hedera-sdk-js

Hedera™ Hashgraph SDK for JavaScript/TypeScript
https://docs.hedera.com/guides/docs/sdks
Apache License 2.0
257 stars 132 forks source link

fix: solve backward compatibility issues between the SDK and hedera-services v0.49 (modularized code) #2240

Closed svetoslav-nikol0v closed 5 months ago

svetoslav-nikol0v commented 6 months ago

Description:

Resolves backward compatibility issues between the SDK and hedera-services v0.48 (modularized code).

Related issue(s):

Fixes #2239

Notes for reviewer:

Whenever one of the pre-existing files is updated, the SonarCloud Code Analysis check fails with [number]% Duplication on New Code (required ≤ 3%).

Checklist

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.26%. Comparing base (5c428d4) to head (97923fa). Report is 58 commits behind head on main.

:exclamation: Current head 97923fa differs from pull request most recent head 4c4ae99. Consider uploading reports for the commit 4c4ae99 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2240 +/- ## ========================================== + Coverage 76.49% 84.26% +7.76% ========================================== Files 304 53 -251 Lines 75800 11432 -64368 ========================================== - Hits 57986 9633 -48353 + Misses 17814 1799 -16015 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
52.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud