hashgraph / hedera-sdk-js

Hedera™ Hashgraph SDK for JavaScript/TypeScript
https://docs.hedera.com/guides/docs/sdks
Apache License 2.0
253 stars 131 forks source link

feat: custom derivation paths in Mnemonic ECDSA private key derivation #2341

Open bguiz opened 2 weeks ago

bguiz commented 2 weeks ago

Description:

What

Why

Related issue(s):

Fixes: https://github.com/hashgraph/hedera-sdk-java/issues/1263#issuecomment-1330953933

Notes for reviewer:

Checklist

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codecov[bot] commented 19 hours ago

Codecov Report

Attention: Patch coverage is 54.66667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (5c428d4) to head (46cab9b). Report is 82 commits behind head on main.

:exclamation: Current head 46cab9b differs from pull request most recent head 5a5b32d

Please upload reports for the commit 5a5b32d to get more accurate results.

Files Patch % Lines
src/Mnemonic.js 54.66% 34 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2341 +/- ## ========================================== - Coverage 76.49% 75.99% -0.51% ========================================== Files 304 230 -74 Lines 75800 58047 -17753 ========================================== - Hits 57986 44114 -13872 + Misses 17814 13933 -3881 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bguiz commented 3 hours ago

@svetoslav-nikol0v + @thenswan 5a5b32d2

Attempt to increase code coverage of src/Mnemonic.js --> https://app.codecov.io/gh/hashgraph/hedera-sdk-js/pull/2341?src=pr&el=tree#23d3b499f82e11bd737b0faf0152911f-R153

Further context: https://swirldslabs.slack.com/archives/C0453UVBR42/p1719635439040999?thread_ts=1717061977.081859&cid=C0453UVBR42