hashgraph / hedera-sdk-swift

Hedera™ SDK for Swift
Apache License 2.0
27 stars 11 forks source link

Add E2E: AccountAllowanceDeleteTransaction #90

Open SimiHunjan opened 1 year ago

SimiHunjan commented 1 year ago

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

Testing the proper functionality of token allowances, particularly for NFTs in Hedera, requires robust integration tests. These tests ensure that once an allowance is deleted, further transfers fail as expected, and verify the system’s behavior when specific serials or all serials are removed from allowances.

Solution

The following are integration test cases for managing and verifying the behavior of token allowances in the Hedera Rust SDK. These tests cover removing allowances for specific NFTs, ensuring transfers fail after deletion, and testing partial or full allowance removal. Reference from Rust: e2e/account/allowance_delete

Implementation

  1. Create an NFT collection
  2. Approve allowances for the NFTs
  3. Delete allowances

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file. A more detailed general documentation of the GitHub PR workflow can be found here.

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

izik1 commented 1 year ago

See: https://github.com/hashgraph/hedera-sdk-rust/issues/519#issuecomment-1577508513

b-l-u-e commented 1 month ago

Please assign me to this issue @hendrikebbers

b-l-u-e commented 3 weeks ago

@hendrikebbers