search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 136 forks source link

fix: `dry-run-enabled` not working correctly on previewnet pipeline #11046

Open jeromy-cannon opened 9 months ago

jeromy-cannon commented 9 months ago

Description

A previewnet pipeline action was triggered with the dry-run setting, but it ran some steps (triggered the Jenkins job) that it was not supposed to.

The workflow needs to be updated to properly carry the dry-run-enabled setting through the various job steps correctly.

Steps to reproduce

  1. open URL: https://github.com/hashgraph/hedera-services/actions/workflows/node-flow-deploy-preview.yaml
  2. click Run workflow
  3. v0.46.0-alpha.3
  4. check Perform Dry Run
  5. click Run workflow button

Additional context

Version: v0.46.0-alpha.3 Pipeline Run: https://github.com/hashgraph/hedera-services/actions/runs/7573015326/job/20624187850 > Slack Thread < Per Nathan: the dry run flag was dropped and not passed to the nested reusable workflow

deploy-tag:
    name: Deploy Tag
    uses: ./.github/workflows/node-zxc-deploy-preview.yaml
    needs:
      - prepare-deploy-preview
    with:
      version-policy: specified
      new-version: ${{ needs.prepare-deploy-preview.outputs.version }}

the above with: clause needs to have a dry-run-enabled: ${{ github.event.inputs.dry-run-enabled == 'true' }} statement added

Hedera network

previewnet

Version

v0.46.0-alpha.3

Operating system

Other

rbarkerSL commented 1 week ago

@jeromy-cannon is this still a needed fix? If so is there a desired integration date?

jeromy-cannon commented 6 days ago

@jeromy-cannon is this still a needed fix? If so is there a desired integration date?

@rbarkerSL , I opened this issue per @nathanklick 's request when it happened. I believe it still needs to be fixed. I have no desired integration date, I would think it would be a low priority issue.