Periodic snapshots during PCES replay don't get signatures - Githubissues

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger

Apache License 2.0

281 stars 125 forks source link

Periodic snapshots during PCES replay don't get signatures #11421

Open litt3 opened 7 months ago

litt3 commented 7 months ago

If a round comes to consensus during PCES replay, and the state is chosen as a periodic snapshot, nodes will fail to get signatures on the state

Solution

will be solved when we have guaranteed state signing

Example analysis

JRS example
- Freeze round is 96
- When nodes come back online after the freeze, round 97 reaches consensus during PCES replay, and is chosen for a periodic snapshot
- No nodes get signatures on round 97, resulting in the eventual error State written to disk for round 97 did not have enough signatures

edward-swirldslabs commented 6 months ago

Another example: http://35.247.76.217:8095/swirlds-automation/release/0.46/4N/Abbrev/20240220-091203-GCP-PRCheck-Abbrev-4N/Consistency-Hard-Restart-10m

edward-swirldslabs commented 5 months ago

Another Example: http://35.247.76.217:8095/swirlds-automation/release/0.47/4N_2C/Ubuntu2204_Update/20240321-104021-GCP-Daily-Update-Ubuntu2204-4N-2C/Crypto-Update-Jar-1.5k-25m/