search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
310 stars 136 forks source link

remove `contracts.evm.version.dynamic` property #12462

Open lukelee-sl opened 6 months ago

lukelee-sl commented 6 months ago

Problem

The contracts.evm.version.dynamic is not implemented in the modularized code.

Solution

Implement a way to have dagger provided the correct EVM version update configuration update.

Alternatives

No response

david-bakin-sl commented 6 months ago

Another possibility would be to make it work, if there was a use case for it (production or testing).

lukelee-sl commented 3 weeks ago

After examining how this configuration is used in mono service, it seems that this is used only by the evm module to allow for loading different versions of the evm for eth_call and eth_estimateGas. We should keep this config around until it is clear that when mirror node consume the smart contract module, it is no longer needed.

david-bakin-sl commented 3 weeks ago

Maybe it could always be true - why not? What does false protect us from? What does true cost us in, say, performance or resources? Then if always true: we also don't need it.

lukelee-sl commented 2 weeks ago

Verified with Ivan that this seems to be no longer needed from an evm module perspective.