hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 138 forks source link

Better encapsulate hapi-fees API via JPMS #1272

Closed tinker-michaelj closed 5 months ago

tinker-michaelj commented 3 years ago

Summary The TxnUsageEstimator component is not, logically, part of the exported API of hapi-fees/.

But it cannot be package-private because the contract/crypto/file/schedule/token sub-packages all rely on its functionality.

We could improve the encapsulation of hapi-fees/ by making it a Java module and declining to export TxnUsageEstimator.

netopyr commented 5 months ago

Closed due to inactivity. Please reopen if you think the issue is still relevant.