search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
281 stars 125 forks source link

Test `:test-clients:hapiTestSmartContract` has multiple gRPC "possibly CATASTROPHIC" errors #13008

Open david-bakin-sl opened 4 months ago

david-bakin-sl commented 4 months ago

:test-clients:hapiTestSmartContract shows up in CI as "HAPI Tests (Smart Contract) / Standard", and it's logs report multiple ERRORs from gRPC:

image

These probably indicate the test is sending transactions that are too large ("More than 6144 received") which in turn probably means the test isn't testing what we think it is.

See also #13004 (in case the logged error is changed before you take this issue).

hapiTestSmartContract.log

MiroslavGatsanoga commented 4 months ago

Closing the issue since it looks like this was fixed in https://github.com/hashgraph/hedera-services/pull/13029 (example run from a recent PR has the check passing).

netopyr commented 4 months ago

PR #13029 fixed the catastrophic failure. This issue is about the tests that caused the failure:

These probably indicate the test is sending transactions that are too large ("More than 6144 received") which in turn probably means the test isn't testing what we think it is.

MiroslavGatsanoga commented 4 months ago

Checking the hapiTestSmartContract.log from above looks like we get a single "More than 6144 received" log which I think is from the cannotCreateTooLargeContract e2e test which is passing. Other errors seem to be due to fuzzy record matching differences but they don't seem related to "More than 6144 received" case. Will try to reproduce locally for the whole :test-clients:hapiTestSmartContract but since it is taking a lot of time it might take a while. @david-bakin-sl do you recall what CI job was failing with those or if there were more than one "More than 6144 received" cases in it?

MiroslavGatsanoga commented 4 months ago

Running :test-clients:hapiTestSmartContract for commit 72a15bdaa9 had only cannotCreateTooLargeContract test reporting "More than 6144 received" log.