hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
295 stars 127 forks source link

chore: logging config is automatically reloaded #13919

Closed hendrikebbers closed 4 weeks ago

hendrikebbers commented 3 months ago

Fixes https://github.com/hashgraph/hedera-services/issues/13918

github-actions[bot] commented 3 months ago

Node: HAPI Test (Token) Results

 23 files   23 suites   6m 38s :stopwatch: 282 tests 282 :white_check_mark: 0 :zzz: 0 :x: 365 runs  365 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  4m 58s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Crypto) Results

 35 files   35 suites   12m 16s :stopwatch: 373 tests 373 :white_check_mark: 0 :zzz: 0 :x: 424 runs  424 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Misc) Results

 62 files   62 suites   15m 33s :stopwatch: 316 tests 316 :white_check_mark: 0 :zzz: 0 :x: 415 runs  415 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Time Consuming) Results

 4 files   4 suites   22m 51s :stopwatch: 18 tests 18 :white_check_mark: 0 :zzz: 0 :x: 19 runs  19 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Smart Contract) Results

 93 files   93 suites   24m 40s :stopwatch: 660 tests 660 :white_check_mark: 0 :zzz: 0 :x: 877 runs  877 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Node: HAPI Test (Restart) Results

6 tests   2 :white_check_mark:  3m 16s :stopwatch: 7 suites  0 :zzz: 7 files    4 :x:

For more details on these failures, see this check.

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Node: Unit Test Results

  1 571 files    1 571 suites   4h 19m 58s :stopwatch: 118 218 tests 118 157 :white_check_mark: 59 :zzz: 2 :x: 126 448 runs  126 387 :white_check_mark: 59 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit 61139001.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.05%. Comparing base (6ff782d) to head (2ce6881). Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ava/com/swirlds/config/extensions/ConfigUtils.java 77.77% 2 Missing :warning:
...lds/logging/api/internal/DefaultLoggingSystem.java 92.30% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) ```diff @@ Coverage Diff @@ ## develop #13919 +/- ## ============================================= + Coverage 58.03% 58.05% +0.01% - Complexity 21508 21515 +7 ============================================= Files 2776 2778 +2 Lines 109004 109030 +26 Branches 11174 11175 +1 ============================================= + Hits 63263 63294 +31 + Misses 41872 41867 -5 Partials 3869 3869 ``` | [Files with missing lines](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [...om/swirlds/logging/api/internal/LoggingSystem.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&filepath=platform-sdk%2Fswirlds-logging%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Flogging%2Fapi%2Finternal%2FLoggingSystem.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3N3aXJsZHMtbG9nZ2luZy9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2xvZ2dpbmcvYXBpL2ludGVybmFsL0xvZ2dpbmdTeXN0ZW0uamF2YQ==) | `90.35% <100.00%> (+0.35%)` | :arrow_up: | | [.../internal/configuration/InternalLoggingConfig.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&filepath=platform-sdk%2Fswirlds-logging%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Flogging%2Fapi%2Finternal%2Fconfiguration%2FInternalLoggingConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3N3aXJsZHMtbG9nZ2luZy9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2xvZ2dpbmcvYXBpL2ludGVybmFsL2NvbmZpZ3VyYXRpb24vSW50ZXJuYWxMb2dnaW5nQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...latform/config/PlatformConfigurationExtension.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&filepath=platform-sdk%2Fswirlds-platform-core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fplatform%2Fconfig%2FPlatformConfigurationExtension.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3N3aXJsZHMtcGxhdGZvcm0tY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL3BsYXRmb3JtL2NvbmZpZy9QbGF0Zm9ybUNvbmZpZ3VyYXRpb25FeHRlbnNpb24uamF2YQ==) | `100.00% <ø> (ø)` | | | [...lds/logging/api/internal/DefaultLoggingSystem.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&filepath=platform-sdk%2Fswirlds-logging%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Flogging%2Fapi%2Finternal%2FDefaultLoggingSystem.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3N3aXJsZHMtbG9nZ2luZy9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2xvZ2dpbmcvYXBpL2ludGVybmFsL0RlZmF1bHRMb2dnaW5nU3lzdGVtLmphdmE=) | `82.75% <92.30%> (+2.32%)` | :arrow_up: | | [...ava/com/swirlds/config/extensions/ConfigUtils.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&filepath=platform-sdk%2Fswirlds-config-extensions%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fconfig%2Fextensions%2FConfigUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3N3aXJsZHMtY29uZmlnLWV4dGVuc2lvbnMvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9jb25maWcvZXh0ZW5zaW9ucy9Db25maWdVdGlscy5qYXZh) | `77.77% <77.77%> (ø)` | | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/13919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)
hendrikebbers commented 1 month ago

@mxtartaglia-sl can you help me and have a look at LoggingSystemTesttestConfigUpdate ?

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% (target: -1.00%) :white_check_mark: 88.89%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (6ff782d5528ecc94d21ad1038106178b827440b7) | 108821 | 67022 | 61.59% | | | Head commit (2ce6881cd732e4c98daa9361a5ae72867b88e7f1) | 108847 (+26) | 67053 (+31) | 61.60% (**+0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#13919) | 27 | 24 | **88.89%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more