search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
295 stars 127 forks source link

chore: inline pces proposal #13951

Closed cody-littley closed 3 months ago

cody-littley commented 3 months ago

closes #13777

github-actions[bot] commented 3 months ago

Node: HAPI Test (Crypto) Results

 23 files   23 suites   10m 45s :stopwatch: 352 tests 352 :white_check_mark: 0 :zzz: 0 :x: 358 runs  358 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   20m 56s :stopwatch: 605 tests 605 :white_check_mark: 0 :zzz: 0 :x: 657 runs  657 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 50s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  6m 8s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 46s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 55s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 35s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6cbed93d.

github-actions[bot] commented 3 months ago

Node: Unit Test Results

  2 354 files    2 354 suites   2h 43m 19s :stopwatch: 120 225 tests 120 154 :white_check_mark: 71 :zzz: 0 :x: 128 788 runs  128 717 :white_check_mark: 71 :zzz: 0 :x:

Results for commit 6cbed93d.

rbair23 commented 3 months ago

+1, except that I think we may be better off without the extra detail I added in "Core Behaviors". In retrospect, it should have been sufficient to list implementation ideas to explore, or leave it off entirely, rather than specify exactly how it is done.

hendrikebbers commented 3 months ago

I vote -0.5 since the proposal is only understandable for people who worked in the hashgraph team in the past (from my point of view), and the diagrams should have better quality and resolution (inlinePces.png, for example, is missing any description of what is shown in the image).

cody-littley commented 3 months ago

Closing this proposal based on Richard's request to first do experimentation with various strategies.

cody-littley commented 3 months ago

superseded by https://github.com/hashgraph/hedera-services/pull/14056