search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
265 stars 119 forks source link

Metric label proposal #13975

Closed hendrikebbers closed 3 days ago

hendrikebbers commented 1 week ago

Proposal for the metric label api. Fixes #13885

PR of draft with discussion history: https://github.com/hashgraph/hedera-services/pull/13809

github-actions[bot] commented 1 week ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  5m 48s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 6s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: Unit Test Results

  1 536 files    1 536 suites   2h 58m 13s :stopwatch: 108 524 tests 108 465 :white_check_mark: 59 :zzz: 0 :x: 116 818 runs  116 759 :white_check_mark: 59 :zzz: 0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  6m 28s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 29s :stopwatch: 362 tests 362 :white_check_mark: 0 :zzz: 0 :x: 369 runs  369 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   22m 23s :stopwatch: 617 tests 617 :white_check_mark: 0 :zzz: 0 :x: 671 runs  671 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 57s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 16s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 37df5471.

:recycle: This comment has been updated with latest results.

hendrikebbers commented 3 days ago

@netopyr regarding your general comment I would say that you are wrong. Look for example at the following part of the prometheus documentation: https://prometheus.io/docs/prometheus/latest/querying/basics/#instant-vector-selectors

The show how to do query with the following metric definitions:

http_requests_total
http_requests_total{replica="rep-a"}
http_requests_total{replica="rep-b"}
http_requests_total{environment="development"}

As you can see labels are not defined as a fixed list.

hendrikebbers commented 3 days ago

Withdrawn by #14090