search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
266 stars 119 forks source link

chore: Address review comments on #13923 #13996

Closed Neeharika-Sompalli closed 1 week ago

Neeharika-Sompalli commented 1 week ago

Addressed review comments on https://github.com/hashgraph/hedera-services/pull/13923

github-actions[bot] commented 1 week ago

Node: Unit Test Results

  1 545 files    1 545 suites   2h 57m 17s :stopwatch: 108 587 tests 108 528 :white_check_mark: 59 :zzz: 0 :x: 116 881 runs  116 822 :white_check_mark: 59 :zzz: 0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 4s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 59s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  6m 12s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 15s :stopwatch: 362 tests 362 :white_check_mark: 0 :zzz: 0 :x: 369 runs  369 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   20m 33s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   24m 10s :stopwatch: 617 tests 617 :white_check_mark: 0 :zzz: 0 :x: 669 runs  669 :white_check_mark: 0 :zzz: 0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  23m 26s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit cb76814e.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (9973fae) to head (cb76814). Report is 72 commits behind head on develop.

Files Patch % Lines
...rkflows/handle/flow/txn/DefaultHandleWorkflow.java 78.94% 1 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #13996 +/- ## ============================================= - Coverage 67.58% 58.27% -9.32% + Complexity 36486 22066 -14420 ============================================= Files 3732 2870 -862 Lines 149767 109657 -40110 Branches 15571 11160 -4411 ============================================= - Hits 101223 63902 -37321 + Misses 44179 42219 -1960 + Partials 4365 3536 -829 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.