hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 136 forks source link

Remove redundant check for static frame in `CustomSelfDestructOperation`. #14037

Closed lukelee-sl closed 2 months ago

lukelee-sl commented 4 months ago

Problem

The CustomSelfDestructOperation does not descend from or use the Besu implementation of SelfDestructOperation. Perhaps we should for reference even if we do not call the super class.

There is a redundant check for static frame. Analyze if the check can be removed.
We are missing a check for static frames

Solution

Consider descending from the Besu implementation of SelfDestructOperation for reference. Analyze check for static frame and remove redundant check if safe.

Alternatives

No response

MrValioBg commented 4 months ago

Seems like this check already exists. @lukelee-sl Services reference here Besu reference here

Is this it, or am I missing something?

lukelee-sl commented 4 months ago

Seems like this check already exists. @lukelee-sl Services reference here Besu reference here

Is this it, or am I missing something?

@MrValioBg, Good point. For one thing we do not descend from Besu's SelfDestructOperation. I think I was wondering about this line and wondering if this check is necessary if the check is done above as you rightly point out. But you are correct that it seems we have a check. Perhaps the issue should be reworded.

david-bakin-sl commented 2 months ago

Refactor of customselfdestruct mentioned above moved to #14756