hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 136 forks source link

chore: platform design proposal process #14065

Closed poulok closed 4 months ago

poulok commented 4 months ago

Description: Introduces documentation for the new Platform Design Proposal process.

Related issue(s):

Fixes https://github.com/hashgraph/hedera-services/issues/13793

Draft version: https://github.com/hashgraph/hedera-services/pull/13870

github-actions[bot] commented 4 months ago

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   24m 31s :stopwatch: 617 tests 617 :white_check_mark: 0 :zzz: 0 :x: 671 runs  671 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  7m 50s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 41s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 33s :stopwatch: 362 tests 362 :white_check_mark: 0 :zzz: 0 :x: 369 runs  369 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  5m 41s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 55s :stopwatch: 265 tests 265 :white_check_mark: 0 :zzz: 0 :x: 340 runs  340 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 2s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f7542751.

github-actions[bot] commented 4 months ago

Node: Unit Test Results

  1 545 files    1 545 suites   2h 58m 58s :stopwatch: 108 587 tests 108 528 :white_check_mark: 59 :zzz: 0 :x: 116 881 runs  116 822 :white_check_mark: 59 :zzz: 0 :x:

Results for commit f7542751.

poulok commented 4 months ago

+0.6, with my reservation documented here #13870 (comment)

Please do not "approve" the PR unless your vote is a +1

hendrikebbers commented 4 months ago

+1 While I would not call it 100% complete or perfect, having this initial process defined is a really good start.

cody-littley commented 4 months ago

-1

In response to https://github.com/hashgraph/hedera-services/pull/14065#discussion_r1655270490, making it clear that I am voting against the proposal as a whole. Core reason is the requirement to close and reopen the PR after each modification.

mxtartaglia-sl commented 4 months ago

+0.6. A lot of good things. My reservation is something already happened: Losing the conversation history when opening multiple pull requests might negatively impact the quality of the discussions.

poulok commented 4 months ago

Superseded by https://github.com/hashgraph/hedera-services/pull/14083