hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 136 forks source link

feat: set admin_key during migration and unit tests #14072

Closed iwsimon closed 3 months ago

iwsimon commented 4 months ago

Description: Set admin_key during migration. Added more unit tests to make 100% classes and lines covered under hedera-addressbook-service-impl.

Related issue(s):

Fixes #14070

Notes for reviewer:

Checklist

github-actions[bot] commented 4 months ago

Node: Unit Test Results

  1 545 files    1 545 suites   3h 13m 48s :stopwatch: 115 793 tests 115 734 :white_check_mark: 59 :zzz: 0 :x: 124 108 runs  124 049 :white_check_mark: 59 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 43s :stopwatch: 6 tests 6 :white_check_mark: 0 :zzz: 0 :x: 7 runs  7 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 47s :stopwatch: 273 tests 273 :white_check_mark: 0 :zzz: 0 :x: 351 runs  351 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 8s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 28s :stopwatch: 366 tests 366 :white_check_mark: 0 :zzz: 0 :x: 373 runs  373 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 47s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 57s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Node: HAPI Test (Smart Contract) Results

 73 files   73 suites   23m 5s :stopwatch: 628 tests 628 :white_check_mark: 0 :zzz: 0 :x: 682 runs  682 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 29b17fca.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.08%. Comparing base (9973fae) to head (29b17fc). Report is 116 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14072 +/- ## ============================================= - Coverage 67.58% 58.08% -9.51% + Complexity 36486 22063 -14423 ============================================= Files 3732 2868 -864 Lines 149767 110362 -39405 Branches 15571 11278 -4293 ============================================= - Hits 101223 64101 -37122 + Misses 44179 42677 -1502 + Partials 4365 3584 -781 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.