search

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
265 stars 119 forks source link

AddressBookService should be in package `proto` for SDK consistency #14087

Closed jsync-swirlds closed 3 days ago

jsync-swirlds commented 6 days ago

While it is not necessary to place every new service in the same package as every existing service; the team would prefer to keep the services in the SDK grouped in the proto namespace for the time being to minimize confusion or mistakes on the part of SDK developers.

To that end, we need to change the package value on line 3 of the address_book_service.proto file to package proto;. We may also remove the proto prefix from Transaction and TransactionResponse on lines 134, 145, and 157 (see image below), but this is not strictly necessary. image

This change should not affect any other protobuf files, but will have small effects in the Address Book service definition that must be coordinated.

iwsimon commented 3 days ago

hedera-protobufs pr 386 fixed this.