hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
265 stars 119 forks source link

chore: enable update `HapiTest`s #14105

Open tinker-michaelj opened 3 days ago

tinker-michaelj commented 3 days ago

Description:

Includes required fixes for node software,

  1. Captures a node's AddressBook self-name in the Node#description field.
  2. Correctly parses and translatesa ServiceEndpoint into the related Node fields (notably, the ipAddressV4 string is the 4 octets of the IP address, not a UTF-8 string).

👉 Note to reviewer: The node changes are covered by new @HapiTest's and will thus have unit test coverage when test-clients is moved under hedera-app test sources.

Also makes smaller improvements,

github-actions[bot] commented 2 days ago

Node: Unit Test Results

  1 545 files    1 545 suites   3h 40m 14s :stopwatch: 115 799 tests 115 740 :white_check_mark: 59 :zzz: 0 :x: 124 114 runs  124 055 :white_check_mark: 59 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  5m 8s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Token) Results

 22 files   22 suites   7m 29s :stopwatch: 273 tests 273 :white_check_mark: 0 :zzz: 0 :x: 351 runs  351 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 12s :stopwatch: 6 tests 6 :white_check_mark: 0 :zzz: 0 :x: 7 runs  7 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   10m 59s :stopwatch: 364 tests 364 :white_check_mark: 0 :zzz: 0 :x: 371 runs  371 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   20m 33s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  22m 44s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Smart Contract) Results

 73 files   73 suites   22m 22s :stopwatch: 626 tests 626 :white_check_mark: 0 :zzz: 0 :x: 679 runs  679 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2d48b326.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 20 hours ago

Codecov Report

Attention: Patch coverage is 57.14286% with 39 lines in your changes missing coverage. Please review.

Project coverage is 58.10%. Comparing base (9973fae) to head (2d48b32). Report is 102 commits behind head on develop.

Files Patch % Lines
...-app/src/main/java/com/hedera/node/app/Hedera.java 11.76% 15 Missing :warning:
...dera/node/app/workflows/handle/HandleWorkflow.java 0.00% 6 Missing :warning:
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 37.50% 4 Missing and 1 partial :warning:
...in/impl/handlers/NetworkGetVersionInfoHandler.java 55.55% 3 Missing and 1 partial :warning:
...ava/com/hedera/node/app/info/SelfNodeInfoImpl.java 0.00% 2 Missing :warning:
...hedera/node/app/version/HederaSoftwareVersion.java 50.00% 2 Missing :warning:
...in/impl/handlers/ReadableFreezeUpgradeActions.java 89.47% 1 Missing and 1 partial :warning:
...ressbook/impl/validators/AddressBookValidator.java 83.33% 0 Missing and 1 partial :warning:
...dera/node/app/ids/schemas/V0490EntityIdSchema.java 0.00% 1 Missing :warning:
...in/java/com/hedera/node/app/info/NodeInfoImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14105 +/- ## ============================================= - Coverage 67.58% 58.10% -9.49% + Complexity 36486 22061 -14425 ============================================= Files 3732 2868 -864 Lines 149767 110384 -39383 Branches 15571 11271 -4300 ============================================= - Hits 101223 64139 -37084 + Misses 44179 42667 -1512 + Partials 4365 3578 -787 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.