hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
265 stars 119 forks source link

chore: Remove `allowAutoAssociations` feature flag #14110

Closed stoyanov-st closed 9 hours ago

stoyanov-st commented 2 days ago

Description:

With HIP-904 we remove the pre-paying for auto association slots. This change makes the contracts.allowAutoAssociations flag obsolete as it was blocking the setting of maxAutoAssociations for ContractCreate and ContractUpdate transactions. It is no longer the expected behaviour and we are charging for associations at point-of-use. So with this PR we remove the feature flag and adjust or remove related tests.

Related issue(s):

Fixes #13954

Notes for reviewer:

Checklist

github-actions[bot] commented 2 days ago

Node: HAPI Test (Restart) Results

3 tests   3 :white_check_mark:  2m 50s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: Unit Test Results

  1 545 files    1 545 suites   3h 31m 14s :stopwatch: 115 799 tests 115 740 :white_check_mark: 59 :zzz: 0 :x: 124 114 runs  124 055 :white_check_mark: 59 :zzz: 0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 52s :stopwatch: 273 tests 273 :white_check_mark: 0 :zzz: 0 :x: 351 runs  351 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 :white_check_mark:  6m 0s :stopwatch: 3 suites  0 :zzz: 3 files    0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 3s :stopwatch: 364 tests 364 :white_check_mark: 0 :zzz: 0 :x: 371 runs  371 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Misc) Results

 51 files   51 suites   20m 41s :stopwatch: 357 tests 357 :white_check_mark: 0 :zzz: 0 :x: 375 runs  375 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Time Consuming) Results

19 tests   19 :white_check_mark:  23m 2s :stopwatch:  4 suites   0 :zzz:  4 files     0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Node: HAPI Test (Smart Contract) Results

 73 files   73 suites   23m 13s :stopwatch: 626 tests 626 :white_check_mark: 0 :zzz: 0 :x: 679 runs  679 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 75d42c15.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 18 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.10%. Comparing base (9973fae) to head (75d42c1). Report is 101 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14110 +/- ## ============================================= - Coverage 67.58% 58.10% -9.49% + Complexity 36486 22057 -14429 ============================================= Files 3732 2869 -863 Lines 149767 110369 -39398 Branches 15571 11268 -4303 ============================================= - Hits 101223 64130 -37093 + Misses 44179 42661 -1518 + Partials 4365 3578 -787 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.