hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 137 forks source link

Double-check if disk reads are required in throttles #14388

Closed netopyr closed 3 weeks ago

netopyr commented 3 months ago

Depending on the transaction type, it is possible that we do quite a few disk reads while checking the throttles. (See for example ThrottleAccumulator.getAutoAssociationsCount().) As disk reads are expensive, we should double-check if they are really required.

derektriley commented 2 months ago

Currently I see the these disk reads being required as implicit account creations and auto-associations need to be checked at Ingest for various types of transactions (crypto transfer, ethereum tx, potentially schedule create and schedule sign) given we have the CreationLimitsthrottle bucket.

I'll tag up with some other services team members to get their inputs (8/29/2024).