hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
281 stars 125 forks source link

fix: Skip charging association fees for airdrops of FT already existing in the pending state #15066

Closed JivkoKelchev closed 3 weeks ago

JivkoKelchev commented 3 weeks ago

Description:

Skip charging association fees for airdrops of FT already existing in the pending state Related issue(s):

Fixes #15031

Notes for reviewer:

Checklist

codacy-production[bot] commented 3 weeks ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3b23fda243314912833e4eb0f23e35c8a5859c00[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (3b23fda243314912833e4eb0f23e35c8a5859c00) | Report Missing | Report Missing | Report Missing | | | Head commit (28c8d04f69cb4c02addd4eb84d5fa02f72f7d78e) | 110863 | 69240 | 62.46% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#15066) | 28 | 28 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.10%. Comparing base (964661d) to head (28c8d04). Report is 20 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) ```diff @@ Coverage Diff @@ ## develop #15066 +/- ## =========================================== Coverage 59.10% 59.10% + Complexity 22549 22537 -12 =========================================== Files 2902 2895 -7 Lines 111299 111174 -125 Branches 11424 11409 -15 =========================================== - Hits 65783 65710 -73 + Misses 41827 41782 -45 + Partials 3689 3682 -7 ``` | [Files](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [...rvice/token/impl/handlers/TokenAirdropHandler.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066?src=pr&el=tree&filepath=hedera-node%2Fhedera-token-service-impl%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fnode%2Fapp%2Fservice%2Ftoken%2Fimpl%2Fhandlers%2FTokenAirdropHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-aGVkZXJhLW5vZGUvaGVkZXJhLXRva2VuLXNlcnZpY2UtaW1wbC9zcmMvbWFpbi9qYXZhL2NvbS9oZWRlcmEvbm9kZS9hcHAvc2VydmljZS90b2tlbi9pbXBsL2hhbmRsZXJzL1Rva2VuQWlyZHJvcEhhbmRsZXIuamF2YQ==) | `85.14% <100.00%> (+1.10%)` | :arrow_up: | | [.../service/token/impl/util/AirdropHandlerHelper.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066?src=pr&el=tree&filepath=hedera-node%2Fhedera-token-service-impl%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fnode%2Fapp%2Fservice%2Ftoken%2Fimpl%2Futil%2FAirdropHandlerHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-aGVkZXJhLW5vZGUvaGVkZXJhLXRva2VuLXNlcnZpY2UtaW1wbC9zcmMvbWFpbi9qYXZhL2NvbS9oZWRlcmEvbm9kZS9hcHAvc2VydmljZS90b2tlbi9pbXBsL3V0aWwvQWlyZHJvcEhhbmRsZXJIZWxwZXIuamF2YQ==) | `80.39% <100.00%> (+1.01%)` | :arrow_up: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/15066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)