Decouple event constraints from deserialization

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger

Apache License 2.0

313 stars 136 forks source link

Decouple event constraints from deserialization #15208

Closed lpetrovic05 closed 1 month ago

lpetrovic05 commented 2 months ago

There are several validity checks performed on each event received through gossip. If any of these validity checks fail, the event is discarded. The first task is to understand which validity and safety checks are provided by PBJ. The second task is to extract all other checks to a separate step which is performed after deserialization is complete.

This ticket is a prerequisite for https://github.com/hashgraph/hedera-services/issues/15205

lpetrovic05 commented 2 months ago

Listing all the checks that are done on deserialization:

Nullity checks for:
- signature
- creatorId
- softwareVersion
- timeCreated
- transaction
- eventDescriptor.hash
- eventDescriptor.creator
- stateSignatureTransaction.sigBytes
- stateSignatureTransaction.hashBytes
Length check for:
- signature
- event descriptor list
- eventDescriptor.hash
- application transaction
- stateSignatureTransaction.sigBytes
- stateSignatureTransaction.hashBytes