refactor: MerkleRoot / MerkleStateRoot / State cleanup

[thenswan]

WIP

[codacy-production[bot]]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: +0.12% (target: -1.00%)	:white_check_mark: 0.00%

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (4f6fd614c1e53c3c3243ad2d0e27ec38054d53e7) | 96311 | 62524 | 64.92% | | | Head commit (21a9891b7810ee5b80792731c755f0bf8e3ec16b) | 96336 (+25) | 62656 (+132) | 65.04% (**+0.12%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#16352) | 84 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.

Project coverage is 63.29%. Comparing base (4f6fd61) to head (21a9891). Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...irlds/platform/util/NoOpMerkleStateLifecycles.java	0.00%	40 Missing :warning:
...java/com/swirlds/demo/iss/ISSTestingToolState.java	0.00%	4 Missing :warning:
...rlds/demo/migration/MigrationTestingToolState.java	0.00%	4 Missing :warning:
...wirlds/demo/platform/PlatformTestingToolState.java	0.00%	4 Missing :warning:
...emo/stats/signing/StatsSigningTestingToolMain.java	0.00%	4 Missing :warning:
...om/swirlds/demo/stress/StressTestingToolState.java	0.00%	4 Missing :warning:
...s/demo/addressbook/AddressBookTestingToolMain.java	0.00%	3 Missing :warning:
...s/demo/consistency/ConsistencyTestingToolMain.java	0.00%	3 Missing :warning:
.../java/com/swirlds/demo/iss/ISSTestingToolMain.java	0.00%	3 Missing :warning:
...irlds/demo/migration/MigrationTestingToolMain.java	0.00%	3 Missing :warning:
... and 5 more

Additional details and impacted files

[](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) ```diff @@ Coverage Diff @@ ## develop #16352 +/- ## ============================================= + Coverage 63.17% 63.29% +0.11% - Complexity 20003 20051 +48 ============================================= Files 2524 2523 -1 Lines 93492 93517 +25 Branches 9793 9796 +3 ============================================= + Hits 59068 59195 +127 + Misses 30830 30723 -107 - Partials 3594 3599 +5 ``` | [Files with missing lines](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [.../demo/addressbook/AddressBookTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FAddressBookTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Faddressbook%2FAddressBookTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vYWRkcmVzc2Jvb2svQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../demo/consistency/ConsistencyTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FConsistencyTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fconsistency%2FConsistencyTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQ29uc2lzdGVuY3lUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vY29uc2lzdGVuY3kvQ29uc2lzdGVuY3lUZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...mo/stats/signing/StatsSigningTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FStatsSigningTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fstats%2Fsigning%2FStatsSigningTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvU3RhdHNTaWduaW5nVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL3N0YXRzL3NpZ25pbmcvU3RhdHNTaWduaW5nVGVzdGluZ1Rvb2xTdGF0ZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...s/demo/addressbook/AddressBookTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FAddressBookTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Faddressbook%2FAddressBookTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vYWRkcmVzc2Jvb2svQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...s/demo/consistency/ConsistencyTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FConsistencyTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fconsistency%2FConsistencyTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQ29uc2lzdGVuY3lUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vY29uc2lzdGVuY3kvQ29uc2lzdGVuY3lUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../java/com/swirlds/demo/iss/ISSTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FISSTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fiss%2FISSTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvSVNTVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL2lzcy9JU1NUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...irlds/demo/migration/MigrationTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FMigrationTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fmigration%2FMigrationTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvTWlncmF0aW9uVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL21pZ3JhdGlvbi9NaWdyYXRpb25UZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...swirlds/demo/platform/PlatformTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FPlatformTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fplatform%2FPlatformTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvUGxhdGZvcm1UZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vcGxhdGZvcm0vUGxhdGZvcm1UZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...com/swirlds/demo/stress/StressTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FStressTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fstress%2FStressTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvU3RyZXNzVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL3N0cmVzcy9TdHJlc3NUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...java/com/swirlds/demo/iss/ISSTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FISSTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fiss%2FISSTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvSVNTVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL2lzcy9JU1NUZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | | ... and [59 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) [](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)