hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 138 forks source link

chore: Do stricter gossip cert validations #16710

Closed tinker-michaelj closed 4 hours ago

tinker-michaelj commented 1 day ago

Description:

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.50%. Comparing base (5dc2d36) to head (7a384eb). Report is 19 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) ```diff @@ Coverage Diff @@ ## develop #16710 +/- ## ============================================= - Coverage 63.52% 63.50% -0.02% + Complexity 20302 20298 -4 ============================================= Files 2544 2544 Lines 94502 94490 -12 Branches 9871 9868 -3 ============================================= - Hits 60030 60006 -24 - Misses 30864 30873 +9 - Partials 3608 3611 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [...ressbook/impl/validators/AddressBookValidator.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710?src=pr&el=tree&filepath=hedera-node%2Fhedera-addressbook-service-impl%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fnode%2Fapp%2Fservice%2Faddressbook%2Fimpl%2Fvalidators%2FAddressBookValidator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-aGVkZXJhLW5vZGUvaGVkZXJhLWFkZHJlc3Nib29rLXNlcnZpY2UtaW1wbC9zcmMvbWFpbi9qYXZhL2NvbS9oZWRlcmEvbm9kZS9hcHAvc2VydmljZS9hZGRyZXNzYm9vay9pbXBsL3ZhbGlkYXRvcnMvQWRkcmVzc0Jvb2tWYWxpZGF0b3IuamF2YQ==) | `91.80% <100.00%> (+0.42%)` | :arrow_up: | | [...ode/app/service/addressbook/AddressBookHelper.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710?src=pr&el=tree&filepath=hedera-node%2Fhedera-addressbook-service%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fnode%2Fapp%2Fservice%2Faddressbook%2FAddressBookHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-aGVkZXJhLW5vZGUvaGVkZXJhLWFkZHJlc3Nib29rLXNlcnZpY2Uvc3JjL21haW4vamF2YS9jb20vaGVkZXJhL25vZGUvYXBwL3NlcnZpY2UvYWRkcmVzc2Jvb2svQWRkcmVzc0Jvb2tIZWxwZXIuamF2YQ==) | `93.93% <100.00%> (-0.18%)` | :arrow_down: | ... and [19 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)

🚨 Try these New Features:

codacy-production[bot] commented 1 day ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.01% (target: -1.00%) :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (5dc2d36471a53260186245ff7b62f88db666fe83) | 97267 | 63449 | 65.23% | | | Head commit (7a384eb9cc8ebcb39ef237019ee89b491832845a) | 97255 (-12) | 63428 (-21) | 65.22% (**-0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#16710) | 18 | 18 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more