hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger
Apache License 2.0
313 stars 138 forks source link

fix: 15638 Added missing contructor registry initialization to test and demo apps #16715

Closed imalygin closed 1 day ago

imalygin commented 1 day ago

Description:

This is a follow-up for https://github.com/hashgraph/hedera-services/pull/16477. Some nightly tests are failing due to missing initialization blocks that register class IDs of the Merkle state root. This PR fixes the issue.

Related issue(s):

Relates to #15638

Checklist

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 63.45%. Comparing base (1a64bf6) to head (fa5ba0e). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/demo/addressbook/AddressBookTestingToolMain.java 0.00% 14 Missing :warning:
.../java/com/swirlds/demo/iss/ISSTestingToolMain.java 0.00% 14 Missing :warning:
...emo/stats/signing/StatsSigningTestingToolMain.java 0.00% 14 Missing :warning:
...irlds/demo/migration/MigrationTestingToolMain.java 0.00% 13 Missing :warning:
...com/swirlds/demo/stress/StressTestingToolMain.java 0.00% 13 Missing :warning:
...java/com/swirlds/demo/iss/ISSTestingToolState.java 0.00% 2 Missing :warning:
...wirlds/demo/platform/PlatformTestingToolState.java 0.00% 2 Missing :warning:
.../demo/addressbook/AddressBookTestingToolState.java 0.00% 1 Missing :warning:
...swirlds/demo/platform/PlatformTestingToolMain.java 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) ```diff @@ Coverage Diff @@ ## develop #16715 +/- ## ============================================= - Coverage 63.50% 63.45% -0.05% + Complexity 20295 20294 -1 ============================================= Files 2544 2544 Lines 94488 94560 +72 Branches 9868 9868 ============================================= - Hits 60004 60003 -1 - Misses 30873 30945 +72 - Partials 3611 3612 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [.../demo/addressbook/AddressBookTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FAddressBookTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Faddressbook%2FAddressBookTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vYWRkcmVzc2Jvb2svQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...swirlds/demo/platform/PlatformTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FPlatformTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fplatform%2FPlatformTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvUGxhdGZvcm1UZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vcGxhdGZvcm0vUGxhdGZvcm1UZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...java/com/swirlds/demo/iss/ISSTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FISSTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fiss%2FISSTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvSVNTVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL2lzcy9JU1NUZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...wirlds/demo/platform/PlatformTestingToolState.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FPlatformTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fplatform%2FPlatformTestingToolState.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvUGxhdGZvcm1UZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vcGxhdGZvcm0vUGxhdGZvcm1UZXN0aW5nVG9vbFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...irlds/demo/migration/MigrationTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FMigrationTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fmigration%2FMigrationTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvTWlncmF0aW9uVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL21pZ3JhdGlvbi9NaWdyYXRpb25UZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...com/swirlds/demo/stress/StressTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FStressTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fstress%2FStressTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvU3RyZXNzVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL3N0cmVzcy9TdHJlc3NUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...s/demo/addressbook/AddressBookTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FAddressBookTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Faddressbook%2FAddressBookTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9zd2lybGRzL2RlbW8vYWRkcmVzc2Jvb2svQWRkcmVzc0Jvb2tUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../java/com/swirlds/demo/iss/ISSTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FISSTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fiss%2FISSTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvSVNTVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL2lzcy9JU1NUZXN0aW5nVG9vbE1haW4uamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...emo/stats/signing/StatsSigningTestingToolMain.java](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&filepath=platform-sdk%2Fplatform-apps%2Ftests%2FStatsSigningTestingTool%2Fsrc%2Fmain%2Fjava%2Fcom%2Fswirlds%2Fdemo%2Fstats%2Fsigning%2FStatsSigningTestingToolMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-cGxhdGZvcm0tc2RrL3BsYXRmb3JtLWFwcHMvdGVzdHMvU3RhdHNTaWduaW5nVGVzdGluZ1Rvb2wvc3JjL21haW4vamF2YS9jb20vc3dpcmxkcy9kZW1vL3N0YXRzL3NpZ25pbmcvU3RhdHNTaWduaW5nVGVzdGluZ1Rvb2xNYWluLmphdmE=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) [![Impacted file tree graph](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715/graphs/tree.svg?width=650&height=150&src=pr&token=ZPMV8C93DV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)](https://app.codecov.io/gh/hashgraph/hedera-services/pull/16715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)

🚨 Try these New Features:

codacy-production[bot] commented 1 day ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: -0.05% (target: -1.00%) :white_check_mark: 0.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (1a64bf69caa09d701c23de1879e12f13f66b8ec7) | 97253 | 63426 | 65.22% | | | Head commit (fa5ba0eaa761d626d2afae21803ea6b8f1380a3a) | 97325 (+72) | 63426 (+0) | 65.17% (**-0.05%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#16715) | 74 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more