hashgraph / hedera-sourcify

Tools for verifying Hedera smart contracts using standard open source libraries.
Apache License 2.0
6 stars 7 forks source link

Use upstream Sourcify images as a dependency #147

Closed acuarica closed 1 month ago

acuarica commented 2 months ago

Problem

Instead of maintaining our own fork of the verification service, use the images provided by upstream Sourcify directly. This will allow us to avoid duplicating efforts and incorporate new features easily.

For Hedera verification, we decided to directly consume server and repository images from Sourcify upstream. Given that the ui changes might be too Hedera specific, we decided to keep our ui fork with custom modifications.

Solution

The following is a list a features that upstream Sourcify should implement in order to use their images directly.

Server image

Repository image (and select-contract-form UI)

https://repository-verify.hashscan.io/select-contract/ vs https://repo.sourcify.dev/select-contract/

UI image just for completion, we continue to use our own fork

https://verify.hashscan.io/ vs https://sourcify.dev/#/verifier

Given that it might be more difficult to push our customizations in the UI, we might keep our fork of the UI. Thus, these issues are less relevant.

Alternatives

No response