Closed acuarica closed 2 months ago
@svienot @rustyShacklefurd I would like your input here, is there something else we should remove?
@svienot @rustyShacklefurd I would like your input here, is there something else we should remove?
This looks good. I guess we might as well get rid of a couple more scripts:
@svienot @rustyShacklefurd when you have a bit of time, please take a look at this PR, thanks.
Description:
This PR cleans up the repo by removing unused files coming from Sourcify.
.circleci
this is used by upstream Sourcify, not us.vscode
andui/.vscode
unused launch configurationstslint.json
old lint settings, superseded by.eslintrc.js
f855a1c8afe2a5f2ba33ed2032820256b8c6a2c0services/ipfs
unused image, see https://docs.sourcify.dev/docs/repository/#ipfsservices/s3sync
unused image, see https://docs.sourcify.dev/docs/repository/#s3-bucket some files fromscripts/
that might be used by upstream Sourcify 78c4de96a43185c0f30332abf400b2ffa00a55fe, 93b5dde8474a2815471008833913105fff237b60 and ca75ec271b869aa377c3aa6fd7b42ceb9cd718ad.github/PULL_REQUEST_TEMPLATE/release.md
unused PR template ad266cd2c2613da34162b7f6ff44ac03ab686cf5scripts/hedera-reset-(previewnet|testnet).sh
invokehedera-reset.sh
directly frompackage.json
'sscripts
to avoid indirection andscripts
folder pollution 9de95dd02ed60c8b3bec20d5df126ff6ccde2436environments/(build-)?(ipfs|monitor|s3).yaml
docker related configs for unused services a61b2eb056374f1432670213378584ac6aab17e3monitor
service related files c04daf26cc33f7a1da10e05001a37a7430e73608environments/(grafana|loki-config|promtail-config).yaml
satellite service configs 0740bc22a843852fe89f51312248ade617e32010environments/(repository|server|ui).yaml
Hederacompose
configs superseded bydocker-compose-hedera.yaml
b8068f7a48a4ad2c865190e41172e23e1d69906benvironments/.env.(dev|latest|stable)
upstream Sourcify.env
config files not used by Hedera 51eed0e808890efc95bc0a4f1da3dd9f76f3688benvironments/.env.secrets.gpg
unused secrets b3fe1009fe9f0acf8b65401854a26b5ec2192840 and related config files 8fa438dui/.env.(development|production)
old env var templates and updateui/.gitignore
accordingly 99a009aThis PR is a pre-step towards issue #147, where upstream Sourcify images will be consumed directly (except
ui
).The
ui
's landing page is also unused and needs to be removed. However, because removing a page would also require updating theui/package.json
's dependencies, its removal is implemented as part of #160.Related issue(s):
Fixes #142.
Notes for reviewer:
The amount of files removed in this PR got larger then I expected. As a recommendation, it might be easier for reviewers to look at each commit individually. Moreover, next to each item is the commit that delete it.