search

hashgraph / hedera-sourcify

Tools for verifying Hedera smart contracts using standard open source libraries.
Apache License 2.0
6 stars 7 forks source link

feat: add dry run parameter to /session/input-files and /session/verify-checked end-points #92

Closed svienot closed 6 months ago

svienot commented 6 months ago

Description:

Add optional dryrun query parameter to the 2 endpoints of the session API (/session/input-files and /session/verify-checked) used by mirror-node explorer. When the parameter is present and set to true, the result of the (successful) verification is not stored in the repository.

Related issue(s):

Fixes #90

Nana-EC commented 6 months ago

Looks good but is there a way to add a test to ensure

  1. no persistent when dry run is true
  2. no errors when dry run is not set

Confirmed offline with @svienot than manual confirmation was done and follow up PR will capture the rest

svienot commented 6 months ago

Issue capturing the need for API end-points regression tests: #93