search

hashgraph / hedera-transaction-tool-demo

The Hedera Transaction Tool demo application.
Apache License 2.0
9 stars 9 forks source link

Transaction passes collation, but fails in submission #174

Closed SimiHunjan closed 2 years ago

SimiHunjan commented 2 years ago

Description

User signs a transaction with the required signatures -> collation process is successful -> transaction fails with invalid signatures.

2021-12-17 13:06:05.673 [main] ERROR com.hedera.hashgraph.client.cli.ToolsMain.main(ToolsMain.java:60) - Error in executing command: class com.hedera.hashgraph.client.cli.options.SubmitCommand, message: java.util.concurrent.ExecutionException: com.hedera.hashgraph.client.core.exceptions.HederaClientRuntimeException: com.hedera.hashgraph.sdk.PrecheckStatusException: Hedera transaction 0.0.76@1639746360.10000 failed pre-check with the status INVALID_SIGNATURE

Steps to reproduce

  1. Create a transaction
  2. Sign the transaction with valid signatures
  3. Submit the transaction to the network

Additional context

No response

Hedera network

mainnet

Version

v0.3.0

Operating system

Other

SimiHunjan commented 2 years ago

The transactions the users signed had different max transaction fee values that caused the failure.

Solution: Collate should verify all transactions have the same transaction values before successfully collating. If they do not, the collation should fail and provide an error message to the user describing the reason the transaction failed to collate.

Remove that max transaction fee default value set in the tool and instead use the value to be set in the CSV and on the creation screens instead.

The application should not override transaction values set in the CSV file.

All transaction defaults should be app set and not adjustable.

Any adjustments should be made in the transaction create screen.