search

hashgraph / hedera-wallet-connect

This package is a messaging relay between decentralized applications and wallets in Hedera network based on Wallet Connect relays.
Apache License 2.0
7 stars 15 forks source link

Implementation of `getAccountKey()` in `DAppSigner` #184

Open regcs opened 3 weeks ago

regcs commented 3 weeks ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I wanted to extract the public key of the connected account via the getAccountKey() method. However, I encountered a Error: Method not Implemented. Obviously, this method is not implemented here:

https://github.com/hashgraph/hedera-wallet-connect/blob/88a34824452c4ce28c079d1ad119a998944c5262/src/lib/dapp/DAppSigner.ts#L114

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like to have this implemented and wonder what reason there is, that this was not implemented initially. Anyone, who can comment on this?

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

None

Additional context Add any other context or screenshots about the feature request here.

None

AdrianKBL commented 2 weeks ago

Not sure why is not implemented @regcs , I'm gonna ping @hgraphql , in the meantime you could get that value doing a fetch to the MirrorNode with the account logged.

regcs commented 2 weeks ago

Thanks, Adrian. I am using the mirror node as a workaround already now. It's not super urgent, I just saw it's not implemented and thought it might just have been forgotten. Thanks for pinging @hgraphql 😊