hashgraph / hedera-wallet-connect

This package is a messaging relay between decentralized applications and wallets in Hedera network based on Wallet Connect relays.
Apache License 2.0
8 stars 17 forks source link

Vanilla javascript example and documentation #236

Open louweal opened 1 month ago

louweal commented 1 month ago

The Readme says: "This repository includes a vanilla html/css/javascript implementation with a dApp and wallet example useful for testing and development while integrating WalletConnect and Hedera." But there is only a React example? A vanilla javascript example would be very much appreciated since only 5% of websites use React.

The readme also says: 'Use a QR code scanning library to scan and obtain the URI'. Please give the reader some pointers where to start. Or even better, include it in the example.

I really appreciate the work of the Hedera team, however currently I feel like can't migrate from hashconnect to this method, because the overall documentation feels incomplete and examples seem to be missing.

tmctl commented 4 weeks ago

hi @louweal thanks for opening up an issue

the vanilla examples are actually in another folder - https://github.com/hashgraph/hedera-wallet-connect/tree/main/src/examples/typescript

for the modal - this is how it is invoked - https://github.com/hashgraph/hedera-wallet-connect/blob/c59a9ad3333b15b027a0260b63961a7c2327af99/src/examples/typescript/dapp/main.ts#L159

It is confusing to to have 2 folders with examples, we should move the vanilla typescript example to the same folder as the react example (the typescript example actually precluded the react one, but maybe shouldn't be buried in the src folder)

I can put these improvements in my backlog, though we very much welcome PRs if you would like to contribute