v1.3.6 Improved Session Handling and Logging

kantorcodes commented 3 weeks ago

Description:

This PR suggests a number of fixes to improve the dApp experience:

Enables dApps to specify a log level for better control of console logs.
Ensures that there is only one Signer per AccountId + ExtensionId combination. Having multiple signers with different ids created issues in pulling the correct record.
Explores better state management and automatic removal of stale sessions.

Related issue(s):

Fixes CON-494

Notes for reviewer:

We need to merge https://github.com/hashgraph/hedera-wallet-connect/pull/317 first and then update this branch before merging this in.
These updates are substantial and should be a net positive on the experience, but require careful review from the dApp experience. Wallet experiences should remain mostly the same.

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

github-actions[bot] commented 3 weeks ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	35.27% (-3.33% 🔻)	225/638
🔴	Branches	25% (-3.3% 🔻)	31/124
🔴	Functions	23.49% (-2.07% 🔻)	35/149
🔴	Lines	36.13% (-3.56% 🔻)	211/584

Show new covered files 🐣

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🔴 |

`...` / logger.ts

| 25% | 0% | 16.67% | 25% |

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🔴 |

`...` / index.ts

|

15.53% (-4.33% 🔻)

|

17.5% (-4.72% 🔻)

|

6.25% (-1.44% 🔻)

|

16.84% (-4.74% 🔻)

| | 🔴 |

`...` / DAppSigner.ts

|

44.71% (-0.53% 🔻)

| 26.09% |

36% (-1.5% 🔻)

|

44.44% (-1.13% 🔻)

|

Test suite run success

25 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 9b42a86a64bc36de010f23f44c2fddbbe44abb5d

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 6.97674% with 40 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b3600fd). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/lib/dapp/index.ts	8.33%	30 Missing and 3 partials :warning:
src/lib/dapp/DAppSigner.ts	0.00%	3 Missing and 1 partial :warning:
src/lib/shared/utils.ts	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #324 +/- ## ======================================= Coverage ? 36.05% ======================================= Files ? 14 Lines ? 613 Branches ? 80 ======================================= Hits ? 221 Misses ? 372 Partials ? 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hashgraph / hedera-wallet-connect