Closed kantorcodes closed 2 weeks ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 74.76% (+36.16% πΌ) |
462/618 |
π΄ | Branches | 58.59% (+30.29% πΌ) |
75/128 |
π‘ | Functions | 75.51% (+49.95% πΌ) |
111/147 |
π‘ | Lines | 75.74% (+36.05% πΌ) |
434/573 |
108 tests passing in 11 suites.
Report generated by π§ͺjest coverage report action from 9534961b694728a22a07e0335ca74a3e77c89f84
Attention: Patch coverage is 15.66265%
with 70 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
main@5ae78a5
). Learn more about missing BASE report.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description:
We discovered that certain transactions e.g.
AccountCreateTransactions
with a threshold key would fail to return a receipt whenexecuteWithSigner
was called on the transaction.Under the hood,
call
was being executed in the DAppSigner and attempting to run the query through the wallet. Because these queries are free, we should utilizegetReceipt
instead to ensure consistency and reliability for these complex transactions.Additionally, we should avoid guessing and running both a query and transaction when
call
is used by the Hedera SDK. This would return the following incorrect errorRelated issue(s):
Fixes https://github.com/hashgraph/hedera-wallet-connect/issues/337
Notes for reviewer:
dev:react-demo
and running the newest example for creating a multi signature account at the bottom of the demo. The receipt will return instantly instead of hanging.Checklist