search

hashgraph / solo

An opinionated CLI tool to deploy and manage standalone test networks.
Apache License 2.0
3 stars 4 forks source link

Add a command line flag to accept a values.yaml #496

Open edwin-greene opened 1 month ago

edwin-greene commented 1 month ago

Feature to Enhance

Solo command line flags and custom chart values.

Requested Enhancement

Solo has the -d flag but it requires an entire directory. To enable acceptance tests, the mirror node only needs to make some changes to the default values.yaml that Solo uses. To use Solo in a Github workflow with this change, at the moment it appears that we need to copy/paste Solo's chart directory, instead of just passing it the values we need added to the values.yaml.

The values.yaml passed on the command line should be in addition to the default values that Solo already uses, and any conflicting values should be overwritten with the command line version.

Business Need

To enable the use of Solo in a Github workflow to run mirror node acceptance tests with each PR or merge to main, the mirror node needs to change the default values in the Fullstack testing values.yaml to enable acceptance tests. We can do this by copy/pasting the entire directory into our repository (and just editing the values.yaml in our repo) but that is not a good practice. This change is needed to unblock #8513 Test acceptance tests in CI

Additional Context

No response

jeromy-cannon commented 3 weeks ago

We have a flag -values-file, it is available on:

However, it looks like with the example of solo network deploy the values file that solo generates is the last one in the list (right-most), thus, it would take precedence if there were any conflicts. So, this might need to get updated.

You can specify the '--values'/'-f' flag multiple times. The priority will be given to the last (right-most) file specified.