hashgraph / solo

An opinionated CLI tool to deploy and manage standalone test networks.
Apache License 2.0
27 stars 7 forks source link

fix: Error in `node update` separate commands when new admin key is not supplied #854

Closed Ivo-Yankov closed 1 day ago

Ivo-Yankov commented 2 days ago

Fixes a parsing error in solo node update-submit-transactions and solo node update-execute that prevented the commands from executing. It was occurring when no --new-admin-key was specified.

github-actions[bot] commented 2 days ago

Unit Test Results - Linux

  1 files   35 suites   3s ⏱️  95 tests  95 ✅ 0 💤 0 ❌ 104 runs  104 ✅ 0 💤 0 ❌

Results for commit 2e1a83c9.

github-actions[bot] commented 2 days ago

Unit Test Results - Windows

  1 files   35 suites   12s ⏱️  95 tests  95 ✅ 0 💤 0 ❌ 104 runs  104 ✅ 0 💤 0 ❌

Results for commit 2e1a83c9.

github-actions[bot] commented 2 days ago

E2E Test Report

 16 files  109 suites   1h 2m 58s ⏱️ 226 tests 226 ✅ 0 💤 0 ❌ 229 runs  229 ✅ 0 💤 0 ❌

Results for commit 2e1a83c9.

github-actions[bot] commented 2 days ago

E2E Test Report

 16 files  109 suites   1h 2m 58s ⏱️ 226 tests 226 ✅ 0 💤 0 ❌ 229 runs  229 ✅ 0 💤 0 ❌

Results for commit 2e1a83c9.

codacy-production[bot] commented 2 days ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9a5c920f5b29d3763c6203d9f0aeef56038439c4[^1] :white_check_mark: 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9a5c920f5b29d3763c6203d9f0aeef56038439c4) | Report Missing | Report Missing | Report Missing | | | Head commit (2e1a83c9bbe0dab2dec6597724a967e87dbe2b39) | 13589 | 11871 | 87.36% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#854) | 8 | 8 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.