hashicorp-forge / grove

A Software as a Service (SaaS) log collection framework.
https://hashicorp-forge.github.io/grove/
Mozilla Public License 2.0
130 stars 11 forks source link

Handle HTTP 429s from Github. #30

Closed hcpadkins closed 1 year ago

hcpadkins commented 1 year ago

Overview

This pull request ensures that both HTTP 403s responses with x-ratelimit-remaining: 0, as well as HTTP 429s are handled for rate limiting.

This deviates from Github's existing documentation, which states that HTTP 403s will be used with x-ratelimit-* headers. However, recent rate-limit blog posts from Github mention that HTTP 429 will be used.

Speaking with Github, they have advised that both should be handled.