Closed britton-from-notion closed 4 months ago
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.
Great catch on these, thank you for raising this pull-request to resolve these issues, and for adding the Docker build to CI.
@hcpadkins just following up on this! Cool to merge?
Hey @britton-from-notion,
Sorry for the delay! We've had a few people out over the past week, but this looks good, I'll get this merged now.
Context
When following the instructions in the project README to
docker compose up
to get started, I experienced a few build and run issues. These appear to be related to the infamous compatibility inconsistencies with python projects and docker alpine images. I took a pass at remedying the issue by switching the images to python:3.9-slim and switching the docker compose to reference the root dockerfile, and this fixed the build and runtime issues getting started with Grove.Changes