hashicorp-forge / hermes

A document management system
Mozilla Public License 2.0
1.81k stars 96 forks source link

Couple of fixes to reviews API #625

Closed jfreda closed 6 months ago

jfreda commented 6 months ago

This PR fixes a potential panic if creating a shortcut fails (would result in the shortcut being a nil pointer, which we obviously cannot delete). It also validates that the document status is WIP before allowing creating a review to go through - this could potentially result in multiple reviews for a document (the UI makes this difficult but it was still possible via the API).