`Resource.Expand()` is not recursive enough

hashicorp / aws-cloudformation-resource-schema-sdk-go

This package provides AWS CloudFormation Resource Schema functionality in Go

Mozilla Public License 2.0

4 stars 2 forks source link

`Resource.Expand()` is not recursive enough #11

Closed ewbankkit closed 3 years ago

ewbankkit commented 3 years ago

If a deeply-nested definition contains a $ref, Resource.Expand does not expand the reference, leading to an empty type in the expanded Resource's properties. It seems like Resource.Expand only expands one level of nested properties.

ewbankkit commented 3 years ago

One level is all that should be required as the documentation says nested properties are not allowed. Pragmatically we could expand any $refs at the second level.