hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

87 stars 28 forks source link

fix: 🐛 add trim() to values when creating tags #2405

Closed cameronperera closed 2 months ago

cameronperera commented 2 months ago

Description

🐛 There was a bug when creating new tags for a worker. The values array did not have trimmed values to remove the empty space.

Screenshots (if appropriate)

https://github.com/user-attachments/assets/6f41b62b-5147-48b8-b2c4-edab6ea01eec

How to Test

Navigate to the create tags route and create an api tag with a comma separated value dev, qa and the request should return a 200.

Checklist

[ ] I have added before and after screenshots for UI changes
[ ] I have added JSON response output for API changes
[ ] I have added steps to reproduce and test for bug fixes in the description
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2024 6:03pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2024 6:03pm